Skip to content

Conversation

@yansern
Copy link
Contributor

@yansern yansern commented Jan 23, 2020

Changes proposed in this Pull Request

  • Increase specificity of .domain-picker__panel-row and .domain-picker__suggestion-item to fix styling regression caused by the incorrect load ordering of css, where gutenboarding stylesheet is loaded first, then wordpress/components stylesheet is loaded later. See Gutenboarding: domain picker texts are centered #38834 (comment)

Testing instructions

  1. Go to http://calypso.localhost:3000/gutenboarding
  2. Enter a site name and click Continue.
  3. Click on the domain picker button on the upper left corner.
  4. Domain picker popover should look like the screenshot below.

Before:
image

After:
image

@yansern yansern requested a review from a team as a code owner January 23, 2020 14:40
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works great, thanks!

@yansern yansern merged commit b068da8 into master Jan 23, 2020
@yansern yansern deleted the fix/gutenboarding-domain-picker-styling-regression branch January 23, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gutenboarding: domain picker texts are centered

4 participants