Skip to content

ETK Nav Sidebar: Use site icon for menu toggle when available #51477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 10 commits into from
Apr 7, 2021
Merged

ETK Nav Sidebar: Use site icon for menu toggle when available #51477

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d68c7b
ETK Nav Sidebar: Use site icon for menu toggle when available
Mar 29, 2021
d26f9da
Fetch site icon from wpcom site settings and match Core styles
Mar 31, 2021
7cf7ee7
Fix styles for Gutenberg 10.2
Apr 1, 2021
53e54df
Fetch site icon from /wp endpoint
Apr 2, 2021
48c176a
Correct entity selector
Apr 2, 2021
9959417
Add animation to hiding button to prevent flash disappearance
Apr 6, 2021
0fd2d76
Adds comment about matching animation
Apr 6, 2021
3b5c3dc
Corrects comment typo
Apr 6, 2021
113c6fb
Address feedback
Apr 6, 2021
2726781
Add flex-shrink fix to avoid icon button from shrinking when title is…
ciampo Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add flex-shrink fix to avoid icon button from shrinking when title is… 
… long
  • Loading branch information
@ciampo
ciampo committed Apr 7, 2021
commit 2726781ce389eb71185e90e301a9351bec383b1e
2 changes: 2 additions & 0 deletions ...iting-toolkit-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ $sidebar-button-text-color: #a2aab2; // former $light-gray-900
.wpcom-block-editor-nav-sidebar-nav-sidebar__dismiss-sidebar-button {
height: $header-height !important;
background-color: $sidebar-nav-header-background-color !important;
// Prevents the icon button from shrinking when the site title goes on 2+ lines
flex-shrink: 0;
}

.wpcom-block-editor-nav-sidebar-nav-sidebar__home-button {
Expand Down