Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1c2db40
Added to basket successfully
ddc22 Apr 19, 2021
b6a8f7a
Styling fixes for domains page
ddc22 Apr 20, 2021
2e2e93f
Final shopping cart designs
ddc22 Apr 21, 2021
780c59b
Add yoast plan on load
ddc22 Apr 22, 2021
a6d810b
RHide recommendation prop added
ddc22 Apr 22, 2021
a14025a
Fix max width
ddc22 Apr 22, 2021
7118ae2
Yoast feature flag cleanup
ddc22 Apr 23, 2021
5ae76c8
Complete initial mobile layout
ddc22 Apr 27, 2021
2016e99
Multiple minor fixes
ddc22 Apr 28, 2021
01d6d0d
Add translation and import fix
ddc22 Apr 28, 2021
f758fdf
Clean up css and reuse components, fix links
ddc22 Apr 29, 2021
84c064f
Show recommendation label refactor
ddc22 Apr 29, 2021
19069f0
Introduce emotion based styles
ddc22 Apr 29, 2021
065b99e
Styling fixes and css cleanup and traslation additions
ddc22 May 1, 2021
931cc96
Added rest of the text
ddc22 May 1, 2021
b2b68d8
Fix basket expanding view and other style issues
ddc22 May 2, 2021
59ffe12
Async loading domains route
ddc22 May 3, 2021
2188242
Loading indicators, add to basket on click, remove previous domain fr…
ddc22 May 3, 2021
3879ed3
Remove redundant props
ddc22 May 4, 2021
b54ca83
Simple url string
ddc22 May 4, 2021
71c3ff0
Cosmetic fixes
ddc22 May 4, 2021
f3810b6
Fixed scrollbars
ddc22 May 5, 2021
802f21d
Site preloading task complete, code redundancy fix
ddc22 May 6, 2021
fa68052
Removed cross state tree dipendency import
ddc22 May 6, 2021
3b1d448
Refactor emotion theme code, replace promise with async await, fix ro…
ddc22 May 6, 2021
44ad236
Review fixes
ddc22 May 6, 2021
b745edd
Fix type errors
ddc22 May 6, 2021
c7f5d1a
Remove unecessary url
ddc22 May 7, 2021
fe45139
Merge branch 'trunk' into add/yoast-domain-addition-step
ddc22 May 7, 2021
abcc784
Can be null
ddc22 May 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
RHide recommendation prop added
  • Loading branch information
ddc22 committed May 6, 2021
commit a6d810b307313b9bc12761e212f8b3a99d92d1eb
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ function DomainPickerContainer( { onDomainSelect, selectedDomain } ) {
analyticsFlowId={ MARKETPLACE_FLOW_ID }
onDomainSelect={ onDomainSelect }
currentDomain={ selectedDomain }
hideRecommendationLabel={ true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

={ true } are redundant and can be shortened to:

Suggested change
hideRecommendationLabel={ true }
hideRecommendationLabel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 0aa0786

/>
);
}
Expand Down
6 changes: 5 additions & 1 deletion packages/domain-picker/src/components/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ export interface Props {

/** Vendor string for domain suggestions */
vendor?: string;

/** Hides the recommendation label */
hideRecommendationLabel?: boolean;
}

const DomainPicker: FunctionComponent< Props > = ( {
Expand All @@ -144,6 +147,7 @@ const DomainPicker: FunctionComponent< Props > = ( {
orderSubDomainsLast = false,
onUseYourDomainClick,
vendor = getDomainSuggestionsVendor(),
hideRecommendationLabel = false,
} ) => {
const { __ } = useI18n();
const label = __( 'Search for a domain', __i18n_text_domain__ );
Expand Down Expand Up @@ -400,7 +404,7 @@ const DomainPicker: FunctionComponent< Props > = ( {
}
hstsRequired={ suggestion.hsts_required }
isFree={ suggestion.is_free }
isRecommended={ false && isRecommended }
isRecommended={ hideRecommendationLabel ? false : isRecommended }
railcarId={
baseRailcarId ? `${ baseRailcarId }${ index }` : undefined
}
Expand Down
3 changes: 1 addition & 2 deletions packages/shopping-cart/src/cart-functions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,7 @@ export function addItemsToResponseCart(
responseCart: TempResponseCart,
products: RequestCartProduct[]
): TempResponseCart {
//FIXME: this should be removed before committing
if ( shouldProductsReplaceCart( products, responseCart ) && false ) {
if ( shouldProductsReplaceCart( products, responseCart ) ) {
debug( 'items should replace response cart', products );
return replaceAllItemsInResponseCart( responseCart, products );
}
Expand Down