-
Notifications
You must be signed in to change notification settings - Fork 2k
Added keywords to Spoiler block to improve its discoverability #59636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| __( 'spoiler' ), | ||
| __( 'accordion' ), | ||
| __( 'Dropdown' ), | ||
| __( 'details' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 38 times:
translate( 'Details:' ) ES Score: 8
See 1 additional suggestions in the PR translation status page
|
To add more context on this Issue, it seems there was a limit of 3 keywords when registering a block that was removed at WordPress/gutenberg#13848 PS: From the PR desc it seems the PR aimed to use for searches only the first 3 keywords registered, but judging from the comments below, it seemed there was no cut-off anymore at all The Thanks @ockham for the feedback on this issue |
|
Yep, limit of 3 is no more. 🎉 The "spoiler" keyword is already in title so it's probably not doing anything in the keyword list, not a biggie tho. @lezama Since this is a P2 block, could someone from Lighthouse help test & merge to P2? Should be really quickie. Thank you! 🙌 (Aside, maybe these blocks could be moved to P2 repo?) |
simison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not test-run but code looks good.
Thank you!
|
@simison thanks for the ping! I might be doing something wrong but I can't find the Spoiler block in a P2 — it's not in the block inserter. Is it possible we don't have it on P2s at all? |
|
It does show up for me in P2: It's not a block that's shipped for WP.com/Jetpack customers either. :-) Can you see the other blocks listed here? Testing instructions at #57472 (comment) |
lezama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this block needs a better name and icon 😅
|
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a trunk merge or rebase and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
|
This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR. |

Changes proposed in this Pull Request
Added new keywords to the "spoiler" keyword to improve its discoverability
p4hfux-5YS-p2#comment-8798