-
Notifications
You must be signed in to change notification settings - Fork 2k
Woop: Collect and save store email in site settings #59858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-93519026fa24208bb9f94cee7417f6f32519e027 |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~100 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~9741 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~2652 bytes removed 📉 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Closing in favor of #59970. |
Changes proposed in this Pull Request
Custom hook API changes
In order to deal with options that support multiple values (object shape), the custom hook exposes the new
multipleOptionHadlerfunction. It allows handling the option data kinda easily:In the example above, the
store_emailstores into thewoocommerce_onboarding_profileoption, which has an object shape. Once thesavefunction calls, it performs a POST request passing thewoocommerce_onboarding_profilefield properly:Payload:

Response

Checking the data

Testing instructions
Screen.Recording.2022-01-07.at.12.04.12.PM.mov
Related to #