Skip to content

Conversation

@taipeicoder
Copy link
Contributor

Proposed Changes

This PR updates the styles section of the design preview.

Before After
Screen Shot 2022-10-19 at 5 38 28 PM Screen Shot 2022-10-19 at 5 39 48 PM

Testing Instructions

  • Head to the design picker setup/designSetup?siteSlug=${site_slug}
  • Preview any design with style variations.
  • Ensure that the copy is updated as described above.

Pre-merge Checklist

Related to #

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

@taipeicoder taipeicoder self-assigned this Oct 20, 2022
@taipeicoder taipeicoder requested a review from a team October 20, 2022 01:36
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 20, 2022
@taipeicoder taipeicoder added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 20, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~1 bytes removed 📉 [gzipped])

Details
name                                  parsed_size           gzip_size
async-load-automattic-design-preview        -11 B  (-0.0%)       -1 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented Oct 20, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7584945

Thank you @taipeicoder for including a screenshot in the description! This is really helpful for our translators.

Copy link
Contributor

@miksansegundo miksansegundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@a8ci18n
Copy link

a8ci18n commented Oct 20, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7584945

Thank you @taipeicoder for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 27, 2022

Translation for this Pull Request has now been finished.

@taipeicoder taipeicoder merged commit 8615f23 into trunk Oct 28, 2022
@taipeicoder taipeicoder deleted the update/design-preview-style-variation-text branch October 28, 2022 02:26
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants