Update @wordpress/edit-site #69272

taipeicoder · 2022-10-20T02:16:40Z

Proposed Changes

This PR updates @automattic/design-preview dependency of @wordpress/edit-site from 4.6.0 to 4.17.0, which contains the fixes:

Which, in turn, fixes this UI issue for the <DesignPreview /> component:

Before	After

Testing Instructions

Head to the design picker setup/designSetup?siteSlug=${site_slug}
Preview any design with style variations.
Ensure that the style preview doesn't have extra padding (happened previously for the theme "Pixl").

Pre-merge Checklist

Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?

github-actions · 2022-10-20T02:16:51Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-47009

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-47009&env=jetpack

matticbot · 2022-10-20T02:28:46Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~5049 bytes added 📈 [gzipped])

Details

name                   parsed_size           gzip_size
entry-gutenboarding       +29244 B  (+1.3%)    +4071 B  (+0.6%)
entry-stepper             +15010 B  (+0.4%)    +4727 B  (+0.4%)
entry-main                 +9800 B  (+0.7%)    +3085 B  (+0.9%)
entry-login                +8826 B  (+0.9%)    +2825 B  (+1.0%)
entry-browsehappy           +655 B  (+0.7%)     +121 B  (+0.4%)
entry-domains-landing       +473 B  (+0.1%)     +104 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~8605 bytes added 📈 [gzipped])

Details

name                             parsed_size           gzip_size
gutenberg-editor                     +8041 B  (+1.6%)    +3063 B  (+1.9%)
checkout                             +4421 B  (+0.3%)    +1645 B  (+0.4%)
people                               +3782 B  (+0.6%)    +1471 B  (+0.9%)
site-purchases                       +3769 B  (+0.3%)    +1462 B  (+0.4%)
purchases                            +3769 B  (+0.2%)    +1455 B  (+0.3%)
marketplace                          +3481 B  (+0.5%)    +1501 B  (+0.7%)
media                                +2456 B  (+0.1%)     +801 B  (+0.2%)
home                                 +2347 B  (+0.2%)    +2234 B  (+0.8%)
promote-post                         +2338 B  (+0.7%)     +850 B  (+0.7%)
themes                               +2332 B  (+0.3%)     +710 B  (+0.3%)
settings-writing                     +2321 B  (+0.3%)    +1737 B  (+0.9%)
marketing                            +2321 B  (+0.3%)    +1171 B  (+0.6%)
posts-custom                         +2282 B  (+0.4%)    +1159 B  (+0.6%)
posts                                +2282 B  (+0.4%)    +1159 B  (+0.6%)
theme                                +2241 B  (+0.4%)     +761 B  (+0.5%)
stats                                +2187 B  (+0.3%)      -46 B  (-0.0%)
pages                                +2138 B  (+0.5%)     +688 B  (+0.5%)
comments                             +2130 B  (+0.3%)     +718 B  (+0.4%)
account                              +1740 B  (+0.3%)     +622 B  (+0.4%)
settings                             +1714 B  (+0.2%)     +648 B  (+0.3%)
preview                              +1637 B  (+0.6%)     +615 B  (+0.7%)
customize                            +1637 B  (+0.6%)     +617 B  (+0.7%)
jetpack-cloud-partner-portal         +1615 B  (+0.4%)     +837 B  (+0.7%)
reader                               +1598 B  (+0.3%)     +411 B  (+0.2%)
help                                 +1512 B  (+0.2%)     +607 B  (+0.3%)
woocommerce-installation             +1499 B  (+0.5%)     +556 B  (+0.5%)
settings-discussion                  +1499 B  (+0.4%)     +573 B  (+0.5%)
import                               +1499 B  (+0.4%)     +587 B  (+0.5%)
export                               +1499 B  (+0.5%)     +560 B  (+0.6%)
email                                +1499 B  (+0.2%)     +603 B  (+0.3%)
earn                                 +1499 B  (+0.3%)     +619 B  (+0.4%)
backup                               +1478 B  (+0.2%)     +544 B  (+0.2%)
domains                              +1470 B  (+0.1%)     +575 B  (+0.1%)
plans                                +1302 B  (+0.1%)    +1336 B  (+0.5%)
plugins                              +1092 B  (+0.0%)     +416 B  (+0.1%)
woocommerce                          +1011 B  (+0.4%)     +423 B  (+0.5%)
settings-jetpack                     +1011 B  (+0.3%)     +418 B  (+0.4%)
migrate                              +1011 B  (+0.2%)     +465 B  (+0.4%)
jetpack-social                       +1011 B  (+0.3%)     +471 B  (+0.4%)
jetpack-search                       +1011 B  (+0.2%)     +425 B  (+0.3%)
jetpack-cloud-settings               +1011 B  (+0.2%)     +418 B  (+0.3%)
jetpack-cloud-pricing                +1011 B  (+0.2%)     +433 B  (+0.2%)
jetpack-cloud-agency-dashboard       +1011 B  (+0.2%)     +477 B  (+0.3%)
jetpack-cloud                        +1011 B  (+0.4%)     +417 B  (+0.5%)
google-my-business                   +1011 B  (+0.2%)     +430 B  (+0.3%)
add-ons                              +1011 B  (+0.3%)     +413 B  (+0.4%)
concierge                             +990 B  (+0.2%)     +456 B  (+0.3%)
scan                                  +982 B  (+0.1%)     +392 B  (+0.2%)
activity                              +982 B  (+0.1%)     +392 B  (+0.2%)
settings-security                     +978 B  (+0.2%)     +436 B  (+0.3%)
hosting                               +906 B  (+0.2%)      +62 B  (+0.0%)
signup                                -572 B  (-0.1%)      -32 B  (-0.0%)
accept-invite                         -572 B  (-0.1%)      -32 B  (-0.0%)
jetpack-cloud-plugin-management       +499 B  (+0.1%)     +356 B  (+0.2%)
jetpack-connect                       +439 B  (+0.0%)     +428 B  (+0.1%)
settings-performance                  +316 B  (+0.1%)     +602 B  (+0.3%)
sites-dashboard                       +224 B  (+0.1%)     +299 B  (+0.3%)
notification-settings                 -180 B  (-0.0%)      +94 B  (+0.1%)
site-blocks                           -167 B  (-0.0%)     +101 B  (+0.1%)
security                              -167 B  (-0.0%)      +64 B  (+0.0%)
privacy                               -167 B  (-0.0%)     +107 B  (+0.1%)
me                                    -167 B  (-0.0%)     +107 B  (+0.1%)
happychat                             -167 B  (-0.0%)     +107 B  (+0.1%)
account-close                         -167 B  (-0.0%)     +107 B  (+0.1%)
devdocs                               +150 B  (+0.1%)      +19 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~38233 bytes added 📈 [gzipped])

Details

name                                                                 parsed_size            gzip_size
async-load-automattic-design-preview                                   +106813 B  (+11.6%)   +28679 B  (+10.5%)
async-load-animate-list                                                  -7380 B   (-5.6%)    -2452 B   (-5.7%)
async-load-automattic-help-center                                        +3979 B   (+0.7%)    +1511 B   (+0.9%)
async-load-calypso-my-sites-checkout-modal                               +3698 B   (+0.4%)    +1214 B   (+0.4%)
async-load-calypso-layout-masterbar-checkout-tsx                         +2452 B   (+1.4%)     +898 B   (+1.8%)
async-load-design-blocks                                                 +2335 B   (+0.1%)     +499 B   (+0.1%)
async-load-calypso-blocks-editor-checkout-modal                          +2321 B   (+0.2%)     +875 B   (+0.3%)
async-load-masterbar-help-center                                         +2283 B   (+8.1%)     +880 B  (+10.7%)
async-load-design-wordpress-components-gallery                           +2139 B   (+0.3%)     +661 B   (+0.3%)
async-load-calypso-blocks-inline-help-popover                            +1996 B   (+0.3%)     +773 B   (+0.4%)
async-load-calypso-layout-masterbar-checkout                             +1963 B   (+2.7%)     +740 B   (+3.1%)
async-load-design                                                        +1722 B   (+0.1%)     +604 B   (+0.1%)
async-load-calypso-components-sites-popover                              +1637 B   (+0.9%)     +651 B   (+1.1%)
async-load-design-playground                                             +1239 B   (+0.1%)     +477 B   (+0.1%)
async-load-calypso-components-web-preview-component                      +1114 B   (+0.2%)     +282 B   (+0.2%)
async-load-signup-steps-website-content                                  +1039 B   (+0.7%)     +475 B   (+1.0%)
async-load-signup-steps-p2-complete-profile                              +1039 B   (+0.6%)     +481 B   (+0.9%)
async-load-signup-steps-site-picker                                      +1011 B   (+0.5%)     +481 B   (+0.7%)
async-load-signup-steps-domains                                          +1011 B   (+0.2%)     +480 B   (+0.4%)
async-load-signup-steps-difm-site-picker                                 +1011 B   (+0.5%)     +483 B   (+0.7%)
async-load-signup-steps-woocommerce-install-step-business-info            +998 B   (+0.6%)     +450 B   (+0.9%)
async-load-calypso-post-editor-media-modal                                +854 B   (+0.1%)     +194 B   (+0.0%)
async-load-signup-steps-woocommerce-install-transfer                      +749 B   (+0.8%)     +411 B   (+1.4%)
async-load-signup-steps-woocommerce-install-confirm                       +749 B   (+0.6%)     +406 B   (+1.1%)
async-load-signup-steps-woocommerce-install                               +749 B   (+1.1%)     +407 B   (+1.8%)
async-load-signup-steps-videopress-site                                   +749 B   (+0.7%)     +425 B   (+1.2%)
async-load-signup-steps-user                                              +749 B   (+0.4%)     +430 B   (+0.8%)
async-load-signup-steps-test-step                                         +749 B   (+0.9%)     +408 B   (+1.5%)
async-load-signup-steps-store-features                                    +749 B   (+0.7%)     +401 B   (+1.2%)
async-load-signup-steps-starting-point                                    +749 B   (+0.8%)     +401 B   (+1.3%)
async-load-signup-steps-social-profiles                                   +749 B   (+0.9%)     +410 B   (+1.5%)
async-load-signup-steps-site-type                                         +749 B   (+0.9%)     +406 B   (+1.5%)
async-load-signup-steps-site-title                                        +749 B   (+0.9%)     +410 B   (+1.5%)
async-load-signup-steps-site-or-domain                                    +749 B   (+0.8%)     +404 B   (+1.3%)
async-load-signup-steps-site-options                                      +749 B   (+0.7%)     +403 B   (+1.3%)
async-load-signup-steps-site                                              +749 B   (+0.7%)     +421 B   (+1.3%)
async-load-signup-steps-rewind-were-backing                               +749 B   (+0.9%)     +411 B   (+1.5%)
async-load-signup-steps-rewind-migrate                                    +749 B   (+0.7%)     +414 B   (+1.2%)
async-load-signup-steps-reader-landing                                    +749 B   (+0.9%)     +407 B   (+1.5%)
async-load-signup-steps-plans-atomic-store                                +749 B   (+0.3%)     +419 B   (+0.7%)
async-load-signup-steps-p2-site                                           +749 B   (+0.7%)     +425 B   (+1.2%)
async-load-signup-steps-p2-join-workspace                                 +749 B   (+0.8%)     +411 B   (+1.4%)
async-load-signup-steps-p2-get-started                                    +749 B   (+0.9%)     +405 B   (+1.5%)
async-load-signup-steps-p2-details                                        +749 B   (+0.9%)     +406 B   (+1.5%)
async-load-signup-steps-p2-confirm-email                                  +749 B   (+0.9%)     +408 B   (+1.4%)
async-load-signup-steps-new-or-existing-site                              +749 B   (+0.7%)     +401 B   (+1.2%)
async-load-signup-steps-intent                                            +749 B   (+0.8%)     +401 B   (+1.3%)
async-load-signup-steps-emails                                            +749 B   (+0.6%)     +414 B   (+1.0%)
async-load-signup-steps-design-picker                                     +749 B   (+0.6%)     +411 B   (+1.0%)
async-load-signup-steps-creds-permission                                  +749 B   (+0.7%)     +410 B   (+1.2%)
async-load-signup-steps-creds-confirm                                     +749 B   (+0.7%)     +411 B   (+1.2%)
async-load-signup-steps-creds-complete                                    +749 B   (+0.9%)     +409 B   (+1.5%)
async-load-signup-steps-courses                                           +749 B   (+0.8%)     +415 B   (+1.4%)
async-load-signup-steps-clone-start                                       +749 B   (+0.9%)     +406 B   (+1.4%)
async-load-signup-steps-clone-ready                                       +749 B   (+0.7%)     +410 B   (+1.2%)
async-load-signup-steps-clone-jetpack                                     +749 B   (+0.9%)     +410 B   (+1.5%)
async-load-signup-steps-clone-destination                                 +749 B   (+0.8%)     +414 B   (+1.4%)
async-load-signup-steps-clone-cloning                                     +749 B   (+0.9%)     +408 B   (+1.5%)
async-load-signup-steps-theme-selection                                   +736 B   (+0.5%)     +434 B   (+0.9%)
async-load-signup-steps-clone-point                                       +736 B   (+0.3%)     +421 B   (+0.7%)
async-load-signup-steps-rewind-form-creds                                 +729 B   (+0.6%)     +368 B   (+1.0%)
async-load-signup-steps-clone-credentials                                 +729 B   (+0.6%)     +368 B   (+0.9%)
async-load-signup-steps-add-ons                                           +721 B   (+0.5%)     +405 B   (+0.9%)
async-load-signup-steps-woocommerce-install-step-store-address            +708 B   (+0.5%)     +407 B   (+0.9%)
async-load-calypso-layout-guided-tours-component                          +684 B   (+0.9%)     +429 B   (+2.0%)
async-load-signup-steps-plans                                             +618 B   (+0.2%)     +426 B   (+0.4%)
async-load-signup-steps-page-picker                                       +525 B   (+0.4%)     +102 B   (+0.3%)
async-load-calypso-blocks-app-banner                                      +443 B   (+0.2%)      +62 B   (+0.1%)
async-load-masterbar-cart-masterbar-cart-wrapper                          -320 B   (-0.2%)     -136 B   (-0.3%)
async-load-signup-steps-woocommerce-install-components-support-card       -292 B   (-3.5%)     -127 B   (-3.3%)
async-load-calypso-blocks-jitm-templates-spotlight                        -292 B   (-3.2%)     -124 B   (-3.0%)
async-load-quick-language-switcher                                        +238 B   (+0.2%)     +311 B   (+0.7%)
async-load-calypso-lib-account-settings-helper                            +238 B   (+0.1%)     +319 B   (+0.3%)
async-load-calypso-post-editor-editor-media-modal                         +215 B   (+0.0%)      +45 B   (+0.0%)
async-load-calypso-layout-guided-tours                                    +108 B   (+1.4%)      +52 B   (+2.1%)
async-load-calypso-blocks-support-article-dialog-dialog                    -91 B   (-0.1%)       -7 B   (-0.0%)
async-load-calypso-blocks-jitm-templates-modal                             +51 B   (+0.1%)     +269 B   (+1.1%)
async-load-calypso-components-jetpack-portal-nav                           -28 B   (-0.1%)       -2 B   (-0.0%)
async-load-calypso-components-global-notices                               -28 B   (-0.4%)       -3 B   (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

miksansegundo

LGTM 👍

matticbot · 2022-10-20T03:03:04Z

This PR modifies the release build for o2-blocks

To test your changes on WordPress.com, run install-plugin.sh o2-blocks update/design-preview-bump-package-wordpress-edit-site on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

taipeicoder · 2022-10-25T09:14:56Z

Abandoning this PR in favor of #69363.

taipeicoder mentioned this pull request Oct 20, 2022

Update design-preview UI + bump @wordpress/edit-site to 4.15.0 #69245

Closed

5 tasks

taipeicoder changed the title ~~Bump @wordpress/edit-site~~ Style selection: Fix style preview CSS misalignment Oct 20, 2022

miksansegundo approved these changes Oct 20, 2022

View reviewed changes

miksansegundo mentioned this pull request Oct 20, 2022

[Bug]: Style picker shows scrollbars for Pixl theme #69279

Closed

Bump @wordpress/edit-site

ab1769b

taipeicoder force-pushed the update/design-preview-bump-package-wordpress-edit-site branch from 97c4d2c to ab1769b Compare October 21, 2022 02:57

taipeicoder mentioned this pull request Oct 21, 2022

Style selection: Fix style preview padding #69318

Merged

5 tasks

taipeicoder changed the title ~~Style selection: Fix style preview CSS misalignment~~ Update @wordpress/edit-site Oct 21, 2022

taipeicoder self-assigned this Oct 21, 2022

Fixed test by mocking Date.now

6d8c812

taipeicoder mentioned this pull request Oct 24, 2022

Style selection: Update style variation UI #69363

Merged

5 tasks

taipeicoder closed this Oct 25, 2022

taipeicoder deleted the update/design-preview-bump-package-wordpress-edit-site branch October 25, 2022 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update @wordpress/edit-site #69272

Update @wordpress/edit-site #69272

Uh oh!

taipeicoder commented Oct 20, 2022

Uh oh!

github-actions bot commented Oct 20, 2022 •

edited by matticbot

Loading

Uh oh!

matticbot commented Oct 20, 2022 •

edited

Loading

Uh oh!

miksansegundo left a comment

Uh oh!

matticbot commented Oct 20, 2022

Uh oh!

taipeicoder commented Oct 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update @wordpress/edit-site #69272

Update @wordpress/edit-site #69272

Uh oh!

Conversation

taipeicoder commented Oct 20, 2022

Proposed Changes

Testing Instructions

Pre-merge Checklist

Uh oh!

github-actions bot commented Oct 20, 2022 • edited by matticbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miksansegundo left a comment

Choose a reason for hiding this comment

Uh oh!

matticbot commented Oct 20, 2022

Uh oh!

taipeicoder commented Oct 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 20, 2022 •

edited by matticbot

Loading

matticbot commented Oct 20, 2022 •

edited

Loading