-
Notifications
You must be signed in to change notification settings - Fork 2k
Data Stores: Remove unused reader store #74425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
flootr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
I wonder if this could be useful to keep around for the next time someone wants to gate something behind an "is a11n" flag and they're not in the Calypso client codebase. The original reason the store was added was so Gutenboarding had access to the reader team data to implement such a feature gate. But a future example might be an ETK feature. It can't import Calypso's redux store, but it can import But maybe that's a moot point because there are no new ETK features, only Jetpack features 🤷 |
|
No unused code is useful to keep IMHO 😉 We can always bring it back if necessary - work is never lost in history 😉 |
mashikag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I have the following tasks created that will be implemented within the next 2 weeks. The plan is to introduce the new queries into the reader data-store.
However, as of now I have no clear plans for introducing any new reader redux-store state. On the other hand, there are more queries to come in the near future, I just did not create tasks for them yet.
At the same time, I see no need for any of the store state being removed in this PR, therefore I am approving it.
Proposed Changes
This PR removes the unused Reader store. It hasn't been in use since #54196 landed.
Part of #74399. A follow-up to #73890.
Testing Instructions
Pre-merge Checklist