chore: Upgrades polkadot-sdk to v1.7.2 #599
Open
+2,324
−2,574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thadouk
requested review from
fluorostani,
nahuseyoum and
vukomir
as code owners
thadouk
changed the title
- Updrades the polkadot-sdk to v1.7.2 - Removes eth-bridge dependency from eth-bridge - Restores Rust to 1.85.0 - Updates the version of ethabi, ethereum-types, secp256k1 and web3 used Jira tickets: - SYS-4677 - SYS-4551 - SYS-4677
thadouk
force-pushed
the
feat/upgrade-to-sdk-1.7.2
branch
from
38f7c0f to
2a898ec
Compare
nahuseyoum
approved these changes
Nov 4, 2025
| ethereum-types = "0.14.1" | ||
|
|
||
| pallet-eth-bridge = { path = "../../pallets/eth-bridge"} | ||
| # pallet-eth-bridge = { path = "../../pallets/eth-bridge"} |
Contributor
There was a problem hiding this comment.
Suggested change
| # pallet-eth-bridge = { path = "../../pallets/eth-bridge"} |
| @@ -0,0 +1,5 @@ | |||
| pub const ADD_CONFIRMATION_CONTEXT: &'static [u8] = b"EthBridgeConfirmation"; | |||
Contributor
There was a problem hiding this comment.
I don't have a very strong feeling about this but it seems odd to have pallet specific constants in primitives. Are these used anywhere other than eth-bridge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira tickets:
Type of change/Merge
🚨What type of change is this PR?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Further comments
migrations:
Restores the behaviour of the nomination pools V6ToV7 migration so that it still works when the pallet will be upgraded to V8 afterwards.
try-stateto thepallet_xcmparitytech/polkadot-sdk#3228: [pallet_xcm] Forgotten migration to XCMv4 + added try-state to the pallet_xcmThe current release includes the new XCMv4, so the runtimes must incorporate a migration pallet_xcm::migration::MigrateToLatestXcmVersion to ensure
proper data migration in pallet_xcm.