Skip to content

Conversation

@der3318
Copy link
Member

@der3318 der3318 commented Oct 30, 2024

Purpose

The PR updates several face sample codes that are referenced by learn.microsoft.com. The primary goal is to migrate to the latest version of SDKs, allowing developers to manage face collections (e.g., large person group and large face list) via an administration client.

Language SDK Pull Request Version Change
C# Azure.AI.Vision.Face Azure/azure-sdk-for-net#45402 1.0.0-beta.1 ➡️ 1.0.0-beta.2
Python azure.ai.vision.face Azure/azure-sdk-for-python#37044 1.0.0b1 ➡️ 1.0.0b2
Java com.azure:azure-ai-vision-face Azure/azure-sdk-for-java#41823
Azure/azure-sdk-for-java#42239
1.0.0-beta.1 ➡️ 1.0.0-beta.2

And a couple of minor modifications:

  • Explicitly and clearly set recognition model to 04 in the demo of "find similar faces".
  • The recommended C# naming convention is to use PascalCasing for constants, and camelCase for method parameters.
  • Python, on the other hand, should use snake_case to name variables.
  • Fix the breaking change related to Python's FaceDetectionModel and FaceRecognitionModel enum. For example, change "DETECTION_03" to "DETECTION03".

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

How to Test

Visual Studio 2022 | .NET 8.0 (LTS)

$ dotnet run

Python 3.8.9

$ python Quickstart.py

Microsoft.OpenJDK.11 | Apache Maven 3.9.8

$ mvn clean dependency:copy-dependencies
$ javac -cp target\dependency\* Quickstart.java
$ java -cp .;target\dependency\* Quickstart

@PatrickFarley PatrickFarley merged commit 00df9ae into Azure-Samples:master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants