-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ASIM] Make changes to Authentication ASIM OktaSSO and OktaV2 parser #13401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
oshezaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column_if_exists statements are very expensive as they imply calculated columns later on. There is a reason to why they are used (needed only for V1 tables. I can explain more). It certainly makes prefiltering ineffective. The way around it is to use a union and s datatable:
let empty = datatable (uni_s:string) [];
(Syslog | union empty)
| where uni_s == ""
Parsers/ASimAuthentication/Parsers/vimAuthenticationOktaOSS.yaml
Outdated
Show resolved
Hide resolved
Parsers/ASimAuthentication/Parsers/vimAuthenticationOktaOSS.yaml
Outdated
Show resolved
Hide resolved
Parsers/ASimAuthentication/Parsers/vimAuthenticationOktaOSS.yaml
Outdated
Show resolved
Hide resolved
oshezaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! looks good. Two small comments.
| | where not(disabled) | ||
| | lookup OutcomeReasonLookup on outcome_reason_s | ||
| | extend EventResultDetails = iif(outcome_result_s in (OktaFailedOutcome), coalesce(EventResultDetails, "Other"), "") | ||
| | extend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split between extend for calculated fields and project-rename for just mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Updated in latest iteration
| EventOriginalSubType=legacyEventType_s, | ||
| EventMessage=displayMessage_s, | ||
| EventOriginalResultDetails=outcome_reason_s, | ||
| EventOriginalUid=coalesce(uuid_g, ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for coalesce I think, so can be project-renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By product of initial testing. Removed.
Changes to Authentication OktaSSO parser:
EventSubType --> EventOriginalSubtype Change Rationale:
TargetUserType mapping addition Rationale: