Skip to content

Conversation

@rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Feb 21, 2024

Overview/Summary

This PR is targeting bug report #1485 and it's adding new built-in policies into "Deploy-Private-DNS-Zones" initiative and assignment. All the new policy names are documented on Whats-New file.

This PR fixes/adds/changes/removes

  1. Updated Deploy-Private-DNS-Zones.json
  2. Updated DINE-PrivateDNSZonesPolicyAssignment.json
  3. Updated eslz-portal.json

Breaking Changes

  1. N\A

Testing Evidence

Ekran görüntüsü 2024-02-21 114252
Ekran görüntüsü 2024-02-21 115305
Ekran görüntüsü 2024-02-21 115446

Testing URLs

Azure Public

[Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@rozkurt rozkurt requested a review from a team as a code owner February 21, 2024 10:24
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of changes please @rozkurt

cc: @Springstone

Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Springstone Springstone added PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Type: Enhancement ✨ New feature or request Area: Policy 📝 Issues / PR's related to Policy labels Mar 7, 2024
@Springstone Springstone added this to the policy-refresh-fy24-q3 milestone Mar 7, 2024
@Springstone Springstone closed this Mar 7, 2024
@Springstone Springstone reopened this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Type: Enhancement ✨ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants