-
Notifications
You must be signed in to change notification settings - Fork 48
Fix polymorphic result issue for autorest.go #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e8d62c to
4c8a7d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces common types for Azure resource management version 5, extending the autorest.go test suite for data protection services to support the latest API specifications. The changes primarily focus on adding new JSON schema definitions and corresponding Go models.
- Add comprehensive v5 common type definitions for Azure resource management including types, private links, network security perimeter, managed identity, and customer managed keys
- Extend data protection test coverage with complete client implementations and model definitions
- Add polymorphic result handling support for autorest.go to address compatibility issues
Reviewed Changes
Copilot reviewed 69 out of 74 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| swagger/specification/common-types/resource-management/v5/*.json | New v5 schema definitions for Azure common types including resource management, private links, network security, and identity management |
| packages/autorest.go/test/dataprotection/armdataprotection/*.go | Complete Go SDK implementation for data protection services including clients, models, interfaces, and serialization helpers |
swagger/specification/common-types/resource-management/v5/networksecurityperimeter.json
Show resolved
Hide resolved
swagger/specification/common-types/resource-management/v5/privatelinks.json
Show resolved
Hide resolved
swagger/specification/common-types/resource-management/v5/privatelinks.json
Show resolved
Hide resolved
packages/autorest.go/test/dataprotection/armdataprotection/zz_responses_serde.go
Show resolved
Hide resolved
|
@microsoft-github-policy-service rerun |
|
/check-enforcer evaluate |
resolved: #1697