Skip to content

Conversation

@JiaqiZhang-Dev
Copy link
Member

@JiaqiZhang-Dev JiaqiZhang-Dev commented Sep 4, 2025

resolved: #1697

@JiaqiZhang-Dev JiaqiZhang-Dev marked this pull request as ready for review September 4, 2025 07:06
Copilot AI review requested due to automatic review settings September 4, 2025 07:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces common types for Azure resource management version 5, extending the autorest.go test suite for data protection services to support the latest API specifications. The changes primarily focus on adding new JSON schema definitions and corresponding Go models.

  • Add comprehensive v5 common type definitions for Azure resource management including types, private links, network security perimeter, managed identity, and customer managed keys
  • Extend data protection test coverage with complete client implementations and model definitions
  • Add polymorphic result handling support for autorest.go to address compatibility issues

Reviewed Changes

Copilot reviewed 69 out of 74 changed files in this pull request and generated 5 comments.

File Description
swagger/specification/common-types/resource-management/v5/*.json New v5 schema definitions for Azure common types including resource management, private links, network security, and identity management
packages/autorest.go/test/dataprotection/armdataprotection/*.go Complete Go SDK implementation for data protection services including clients, models, interfaces, and serialization helpers

@JiaqiZhang-Dev
Copy link
Member Author

@microsoft-github-policy-service rerun

@JiaqiZhang-Dev
Copy link
Member Author

/check-enforcer evaluate

@JiaqiZhang-Dev JiaqiZhang-Dev merged commit d4a7a70 into main Sep 5, 2025
10 checks passed
@tadelesh tadelesh deleted the fix_polymorphic_result branch November 25, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autorest.go can not generate polymorphic result for response envelope

4 participants