[Support] Fix error message and added missing conditions (#1567)

Author: mit2nil

src/support/HISTORY.md

@@ -1,9 +1,14 @@
 Release History
 ===============
 
+1.0.2
+-----
+* Removed custom error message in lieu of error message coming from backend.
+* Added missing condition for quota change request payload.
+
 1.0.1
 -----
-* Remove resource id existence check in liue of backend based check
+* Remove resource id existence check in lieu of backend based check
 
 1.0.0
 -----

src/support/azext_support/_validators.py

@@ -44,16 +44,14 @@ def _validate_communication_name(cmd, ticket_name, communication_name):
     rsp = client.check_name_availability(support_ticket_name=ticket_name, name=communication_name,
                                          type="Microsoft.Support/communications")
     if not rsp.name_available:
-        raise CLIError("Support ticket communication name '{0}' not available. ".format(communication_name) +
-                       "Please try again with another name.")
+        raise CLIError(rsp.message)
 
 
 def _validate_ticket_name(cmd, ticket_name):
     client = cf_support_tickets(cmd.cli_ctx)
     rsp = client.check_name_availability(name=ticket_name, type="Microsoft.Support/supportTickets")
     if not rsp.name_available:
-        raise CLIError("Support ticket name '{0}' not available. ".format(ticket_name) +
-                       "Please try again with another name.")
+        raise CLIError(rsp.message)
 
 
 def _validate_problem_classification_name(problem_classification_id):

src/support/azext_support/custom.py

@@ -118,7 +118,7 @@ def create_support_tickets(cmd, client,
     start_date_time = start_date_time.strftime("%Y-%m-%dT%H:%M:%SZ")
     body["problem_start_time"] = start_date_time
 
-    if is_quota_ticket(service):
+    if is_quota_ticket(service) and quota_change_version is not None:
         quotaBody = {}
         quotaBody["quota_change_request_sub_type"] = quota_change_subtype
         quotaBody["quota_change_request_version"] = quota_change_version
@@ -129,7 +129,7 @@ def create_support_tickets(cmd, client,
         quotaBody["quota_change_requests"] = quota_change_requests
         body["quota_ticket_details"] = quotaBody
 
-    if is_technical_ticket(service):
+    if is_technical_ticket(service) and technical_resource is not None:
         body["technical_ticket_details"] = {"resource_id": technical_resource}
 
     logger.debug("Sending create request with below payload: ")

src/support/setup.py

@@ -15,7 +15,7 @@
     logger.warn("Wheel is not available, disabling bdist_wheel hook")
 
 # HISTORY.md entry.
-VERSION = '1.0.1'
+VERSION = '1.0.2'
 
 # The full list of classifiers is available at
 # https://pypi.python.org/pypi?%3Aaction=list_classifiers