Skip to content

Conversation

@mit2nil
Copy link
Member

@mit2nil mit2nil commented Apr 20, 2020

Fix error message and added missing conditions

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/mit2nil/azure-cli-extensions.git@fix_error_message#subdirectory=src/$EXT&egg=$EXT"

@yungezz yungezz requested a review from qwordy April 21, 2020 01:52
@yungezz
Copy link
Member

yungezz commented Apr 21, 2020

HI @qwordy could you pls help to review?

@qwordy qwordy merged commit 09eecf8 into Azure:master Apr 21, 2020
@mit2nil mit2nil deleted the fix_error_message branch April 21, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants