-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add AI examples extension #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6cfdacd
Initial extension creation
mirdaki-ms 043ea9a
Add ability to add Aladdin examples to the default help ones
mirdaki-ms fae34bf
Removed unused boilerplate for Aladdin extension
mirdaki-ms 467d8f3
Add test and clean up Aladdin extension code
mirdaki-ms 1afbd22
Rename extension from Aladdin to "ai-examples"
mirdaki-ms 3cc1cf4
Add a min version of 2.0.80, which should have the hook
mirdaki-ms 5f98770
Update the de-duplication to clean text first
mirdaki-ms 7848e78
Change the default operation to replace the existing examples
mirdaki-ms d8add28
Update summary to be more compliant with guidelines
mirdaki-ms 424d83e
Add ai-examples to index.json as part of publishing
mirdaki-ms 46b7e6c
Update README, remove cli-core dependency, change version for now
mirdaki-ms 8f23d83
Merge branch 'master' into ai-examples
277163f
Update Python and max version number to be accurate
mirdaki-ms c321740
Merge branch 'ai-examples' of https://github.com/mirdaki/azure-cli-ex…
mirdaki-ms 8a08d57
Merge branch 'master' into ai-examples
253ba25
Update to accurate minimum CLI version
mirdaki-ms ede70af
Merge branch 'ai-examples' of https://github.com/mirdaki/azure-cli-ex…
mirdaki-ms ead3587
Merge branch 'master' into ai-examples
mirdaki 53205d5
Update index with new hash and other metadata
mirdaki-ms f8f3a61
Merge branch 'ai-examples' of https://github.com/mirdaki/azure-cli-ex…
mirdaki-ms d9c3666
Switch to CLI download
mirdaki-ms 0836330
Merge branch 'master' into ai-examples
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a min version of 2.0.80, which should have the hook
- Loading branch information
commit 3cc1cf4badb05b969cb78686271b3e7f57e43dc0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "azext.isPreview": true, | ||
| "azext.minCliCoreVersion": "2.0.67", | ||
| "azext.minCliCoreVersion": "2.0.80", | ||
| "azext.maxCliCoreVersion": "2.1.0" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this constraint if you are not sure about the max version requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good suggestion!