Skip to content

Conversation

@mirdaki
Copy link
Contributor

@mirdaki mirdaki commented Mar 3, 2020

This change coincides with this CLI PR to switch the help example hook. Now it directly modifies the help file examples, as opposed to just the method that printed them. This allows examples for commands that don't have any default examples (such as az aks list) and groups.

Note: As this update requires a new version of the CLI to function properly, I need to bump the minor compatible version once that new release is done. I will update the index.json at that point as well.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/mirdaki/azure-cli-extensions.git@newHookAiExamples#subdirectory=src/$EXT&egg=$EXT"

@yonzhan yonzhan requested review from fengzhou-msft and jiasli March 4, 2020 00:32
@yonzhan yonzhan added this to the S166 milestone Mar 4, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 4, 2020

add to S166.

@mirdaki
Copy link
Contributor Author

mirdaki commented Mar 18, 2020

@yonzhan and @jiasli, I've updated the code with the new minimum version. Would you mind reviewing it?

@jiasli
Copy link
Member

jiasli commented Mar 19, 2020

If replacing is the desired behavior, rather than attaching, the PR looks good to me. Merging.

@jiasli
Copy link
Member

jiasli commented Mar 19, 2020

A small off-topic note: you may use the PR link directly https://github.com/Azure/azure-cli/pull/12431 instead of creating your own hyper link with [this CLI PR](https://github.com/Azure/azure-cli/pull/12431).

The link will be automatically converted to Azure/azure-cli#12431. This will be clearer. 😉

@jiasli jiasli merged commit f47fcee into Azure:master Mar 19, 2020
@mirdaki
Copy link
Contributor Author

mirdaki commented Mar 19, 2020

Oh good to know! I'll start doing that from now on.

ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants