[Notification Hub] fix sku and help #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
fengzhou-msft
changed the title
yungezz
approved these changes
Mar 15, 2020
mmyyrroonn
reviewed
Apr 2, 2020
| c.argument('location', arg_type=get_location_type(self.cli_ctx), validator=get_default_location_from_resource_group) | ||
| c.argument('tags', tags_type) | ||
| c.argument('sku_name', arg_type=get_enum_type(['Free', 'Basic', 'Standard']), help='Name of the notification hub sku') | ||
| c.ignore('sku_name') |
Contributor
There was a problem hiding this comment.
This would be a breaking change and user would meet errors. Just want to confirm. If the usage is quite low, it's fine to do it.
mmyyrroonn
reviewed
Apr 2, 2020
| namespace_name, | ||
| notification_hub_name, | ||
| tags=None, | ||
| sku_name=None): |
Contributor
There was a problem hiding this comment.
If you delete it here, I think we don't need the c.ignore
Contributor
There was a problem hiding this comment.
ok. got it. create command still have sku
fengzhou-msft
commented
Apr 2, 2020
src/notification-hub/azext_notification_hub/azext_metadata.json
Outdated
Show resolved
Hide resolved
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a weird bug that in _params.py. I forgot to rename the
sku-nameoption tosku, but it turns out--skucan still be used and the value will be assigned tosku_namecorrectly. That's why previous tests and linter all passed with--sku.Fix Azure/azure-cli#12590.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: