Skip to content

Conversation

@mmyyrroonn
Copy link
Contributor

Fix Azure/azure-cli#12500


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@mmyyrroonn mmyyrroonn requested a review from jsntcy March 17, 2020 04:41
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/MyronFanQiu/azure-cli-extensions.git@breadth-resource-group#subdirectory=src/$EXT&egg=$EXT"

@yonzhan yonzhan requested a review from haroldrandom March 17, 2020 04:57
@yonzhan yonzhan added this to the S167 milestone Mar 17, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 17, 2020

add to S167

@jsntcy jsntcy changed the title [Breadth]Resource Group [Breadth]Resource Graph Mar 20, 2020
Copy link
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonzhan yonzhan modified the milestones: S167, S168 Mar 28, 2020
@mmyyrroonn
Copy link
Contributor Author

/azp run Azure.azure-cli-extensions

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmyyrroonn
Copy link
Contributor Author

/azp run Azure.azure-cli-extensions

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmyyrroonn mmyyrroonn merged commit 6d21d72 into Azure:master Apr 7, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
* bump sdk

* finish code

* hack to fix python sdk

* recording tests

* fix style

* bump sdk and versions

* address comments

* rename it to md

* md

* add experimental
@@ -0,0 +1,58 @@
# Azure CLI blueprint Extension #
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be blueprint, this should Resource Graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Breadth Coverage] Onboard ResourceGraph Commands

5 participants