Skip to content

Conversation

@qianwens
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 17, 2020

add to S167

@haroldrandom
Copy link
Contributor

needs statement of code owner in .github/CODEOWNER.

@rebecca-makar
Copy link
Member

@qianwens I am member of HPC Cache team, this is missing Flush and Upgrade for Cache. Still testing other commands but those two are needed.

@qianwens
Copy link
Member Author

qianwens commented Apr 6, 2020

@qianwens I am member of HPC Cache team, this is missing Flush and Upgrade for Cache. Still testing other commands but those two are needed.

I will add these support in another PR.

@haroldrandom
Copy link
Contributor

file name src/hpc-cache/azext_hpc_cache/tests/latest/test_hpc-cache_scenario.py is a convention,
should be test_hpc_cache_scenario.py

@qianwens
Copy link
Member Author

qianwens commented Apr 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qianwens
Copy link
Member Author

qianwens commented Apr 7, 2020

@qianwens I am member of HPC Cache team, this is missing Flush and Upgrade for Cache. Still testing other commands but those two are needed.

I will add these support in another PR.

I have added flush and upgrade in this PR

@qianwens qianwens merged commit 8c38351 into Azure:master Apr 7, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
* [HPC-Cache] first version

* [HPC-Cache] test case fix

* refine test case

* {hpc-cache} Refine and test

* {hpc-cache} Fix style

* {hpc-cache} add experimental flag

* [HPC-Cache] fix comment

* Update CODEOWNERS

* {hpc-cache} fix the test file name

* {hpc-cache} add flush and upgrade commands

* {hpc-cache} add flush and upgrade commands help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants