Presentation aks fix: The name displayed for the storage is inreality everything before -hcp-, this fix helps clearing that confusion. #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rything before -hcp-, this fix helps clearing that confusion.
Member
Author
|
Tag: Ping reviewer /assign : @xizhamsft + @JunSun17 , Thanks heaps! |
Tatsinnit
changed the title
Collaborator
|
S167 |
gtracer
reviewed
Mar 26, 2020
Contributor
|
LGTM, just make sure you have tested it. |
xizha162
approved these changes
Mar 27, 2020
Member
|
hi @Tatsinnit could you pls add tests to it? thanks. |
Member
Author
|
💡 Test et. al. added, like mentioned I would do another drop next for the generic things I see can be corrected for
Below was the lint failure. FYI:
was |
qwordy
approved these changes
Apr 3, 2020
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
…eality everything before -hcp-, this fix helps clearing that confusion. (Azure#1451) * Presentation fix: The name displayed for the storage is inreality everything before -hcp-, this fix helps clearing that confusion. * Moving to helper + Test following existing pattern. * Pylint issue fixed. Co-authored-by: root <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail this PR trying to achieve:
3 changes:.
Fix
Pylintfailures.Right representation of the Storage URL matching the blobname which gets created. More detail could be found here: Blob with logs is not getting created with az aks kollect command aks-periscope#12 and currently when the storage blob gets created its following the convention under following ARM convention : https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/error-storage-account-name Hence when using persicope user navigate to
storage explorerthey will see blobname you will see logs uploaded under the blob container: example onlyaksaspen2-dns-22701a84and notaksaspen2-dns-22701a84-hcp-eastus2-azmk8s-ioThe
returnis not necessary to be explicit in python, AFAIK. essentiallyreturnorreturn Noneor jsut not mentioning is same. (Unless there is something specific reason, hence detailing here)This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.