Skip to content

Conversation

@qwordy
Copy link
Member

@qwordy qwordy commented Apr 7, 2020

I met an error in CI checks. I cannot reproduce it in my machine. So I edit pipeline in order to show the detailed error.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@qwordy qwordy requested review from haroldrandom and yungezz April 7, 2020 13:50
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/qwordy/azure-cli-extensions.git@alertsmanagement-phase1#subdirectory=src/$EXT&egg=$EXT"

@qwordy qwordy changed the title Alertsmanagement phase1 {Pipeline} print stacktrace when exception Apr 7, 2020
check_call(script_args)
try:
check_call(script_args)
except CalledProcessError as e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why speific this error? what about other errors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It raises this kind of error when it fails according to the doc. It's not recommended to catch a too-broad exception.

@haroldrandom
Copy link
Contributor

It didnt' trigger the desired job runs on alertsmanagement extension.

@qwordy
Copy link
Member Author

qwordy commented Apr 7, 2020

It didnt' trigger the desired job runs on alertsmanagement extension.

I am modifying pipeline definition to show the error. It does not aim to trigger the failed doc job.

@qwordy qwordy merged commit 681775a into Azure:master Apr 7, 2020
@haroldrandom
Copy link
Contributor

It didnt' trigger the desired job runs on alertsmanagement extension.

I am modifying pipeline definition to show the error. It does not aim to trigger the failed doc job.

This job verify extension ref should include alertsmanagement like other extensions, but missing:
image

image

ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants