-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[healthcareapis] Regenerate CLI for export and MI #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello CLI team. I generated this with autorest and it introduced a number of style issues. Should I fix these manually, or is there a better way to fix them? |
|
HealthcareAPIs |
|
As for the style issue, we just run pylint and flake8 on your extension code, you could find the script in azure-cli-extensions/scripts/ci/source_code_static_analysis.py and run some of those checking step manually in your local machine. As for the linter issue, there is a command BTW, why bother to re-generate this extension? |
|
We added two new properties to our service that the CLI needs to support. We had the CLI generated for us when it was first created, so I used the new version of the autorest tool to regenerate the extension with the new properties. Is there another way to update an extension that is preferred? My understanding is that the CLI code is all automatically generated. |
I see. It's really a problem that autorest need to take care, it doesn't consider how to upgrade. So everthing is brand new like new generated. I suggest do not re-generate the extension from initial. We have an automatic release pipeline for developer to release their extension once the code is merged into master branch and your extension has upgraded to higher version. Downgrading version won't trigger the release unless human intervene manually. So, I suggest we take care of this extension uprgade manually, pre-append changes to the history notes and upgrade the extension version. |
|
I reverted the changes to the history and added in a new version for these changes. I've also fixed the lint error for the wait command (we don't have one so I don't know why it was added). |
|
Missed that the regeneration added the experimental flag. It is now removed. |
|
@haroldrandom Is anything else required before merging the PR? |
|
@fengzhou-msft could you please take a look this PR? |
|
@haroldrandom Is it possible to merge the changes? We have some people waiting on the update. |
Regenerated the HealthcareAPIs cli extension to add support for export and managed identity.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?I also ran the tests through azdev.
For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.