Skip to content

Conversation

@kaiqzhan
Copy link
Contributor

@kaiqzhan kaiqzhan commented Oct 13, 2020

Sibling PR in azure-cli: Azure/azure-cli#15376


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/KaiqiZhang/azure-cli-extensions.git@addon-profile-keys#subdirectory=src/$EXT&egg=$EXT"

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 14, 2020

AKS

@yungezz
Copy link
Member

yungezz commented Oct 14, 2020

hi @arrownj could you pls help to review?

@kaiqzhan
Copy link
Contributor Author

@arrownj Any luck to take a look?

@arrownj arrownj merged commit ab3208a into Azure:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants