-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] Add auto upgrade channel to aks create and update #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
AKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Although, I don't know the area well enough to say with certainty :)
There are also a few failing checks that need to be resolved.
yea, I am aware of the failures, waiting for Bo's PR to vendor 11-01 API, and there are a couple of test fixes also. I need to merge once that change is in (I have vendored that locally for testing purpose.) |
arrownj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a possibility to add test for this new parameter ?
| CONST_RAPID_UPGRADE_CHANNEL = "rapid" | ||
| CONST_STABLE_UPGRADE_CHANNEL = "stable" | ||
| CONST_PATCH_UPGRADE_CHANNEL = "patch" | ||
| CONST_NONE_UPGRADE_CHANNEL = "none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these values defined in the swagger and have been defined as Enum in the SDK ? If yes, we may be able to leverage it instead of defining separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are defined in the swagger, however, consts file does depend on the versioned SDK, not sure if it's the reason that we are defining these consts here (don't want to introduce dependency?). Probably I am going to break the pattern and keep it consistent for now. :)
yes, I've added a test (and recording), please take a look |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2694 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.