-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(arcdata): Welcome arcdata v0.0.1 preview #3461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore(arcdata): Welcome arcdata v0.0.1 preview
|
arcdata |
src/index.json
Outdated
| }, | ||
| "extras": [], | ||
| "generator": "bdist_wheel (0.30.0)", | ||
| "keywords": ["az", "sql", "arcdata", "cli", "azure", "sqlmi", "dc"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need you update the keywords of application-insights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kairu-ms - These come from setup.py/dist-info/METADATA hence needed for ./scripts/ci/test_index.py to pass
Is the convention/ask to leave keyword blank for exts?
Thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are changing the keywords of application-insights which is an extension owned by another team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... Let us remove the keywords to dedicated values and push again. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kairu-ms - I removed the offending keywords as suggested. When time permits please review one more time. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swells The keywords are in wrong place. Your extension is arcdata, but you are adding keywords in application-insights extension.
| "keywords": ["az", "sql", "arcdata", "cli", "azure", "sqlmi", "dc"], |
chore(arcdata): Welcome arcdata v0.0.1 preview
chore(arcdata): Welcome arcdata v0.0.1 preview
Introduce arcdata v0.0.1 preview. The source is housed in an external repository and not here.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: