Skip to content

Conversation

@swells
Copy link
Contributor

@swells swells commented Jun 3, 2021

chore(arcdata): Welcome arcdata v0.0.1 preview

Introduce arcdata v0.0.1 preview. The source is housed in an external repository and not here.


General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?
→ python scripts/ci/test_index.py -q
----------------------------------------------------------------------
Ran 9 tests in 103.891s


OK (skipped=2)
→  azdev linter --include-whl-extensions arcdata


Results 
=========

-  pass: faulty_help_example_parameters_rule 
-  pass: faulty_help_example_rule 
-  pass: faulty_help_type_rule 
-  pass: unrecognized_help_entry_rule 
-  pass: unrecognized_help_parameter_rule 
-  pass: expired_command_group 
-  pass: missing_group_help 
-  pass: expired_command 
-  pass: missing_command_help 
-  pass: no_ids_for_list_commands 
-  pass: bad_short_option 
-  pass: expired_option 
-  pass: expired_parameter 
-  pass: missing_parameter_help 
-  pass: no_parameter_defaults_for_update_commands 
-  pass: no_positional_parameters 
-  pass: option_length_too_long 
-  pass: option_should_not_contain_under_score 

No violations found for linter rules.

Run custom pylint rules.
Running pylint on extensions...

No violations found for custom pylint rules.
Linter: PASSED

For new extensions:

chore(arcdata): Welcome arcdata v0.0.1 preview
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 3, 2021

arcdata

src/index.json Outdated
},
"extras": [],
"generator": "bdist_wheel (0.30.0)",
"keywords": ["az", "sql", "arcdata", "cli", "azure", "sqlmi", "dc"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need you update the keywords of application-insights?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms - These come from setup.py/dist-info/METADATA hence needed for ./scripts/ci/test_index.py to pass

Is the convention/ask to leave keyword blank for exts?

Thanks in advance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are changing the keywords of application-insights which is an extension owned by another team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see... Let us remove the keywords to dedicated values and push again. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms - I removed the offending keywords as suggested. When time permits please review one more time. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swells The keywords are in wrong place. Your extension is arcdata, but you are adding keywords in application-insights extension.

Suggested change
"keywords": ["az", "sql", "arcdata", "cli", "azure", "sqlmi", "dc"],

@kairu-ms kairu-ms merged commit a009929 into Azure:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants