Skip to content

add az vmware script* #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 15 commits into from
Aug 12, 2021
Merged

add az vmware script* #3722

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f129c94
custom action for script execution params
cataggar Jul 26, 2021
74ced2d
script-execution tests recorded
cataggar Jul 29, 2021
0542e07
package and cmdlet tests passing
cataggar Jul 29, 2021
b0ebe65
update help
cataggar Jul 29, 2021
99bda24
add named outputs
cataggar Jul 29, 2021
6833ac0
recording are generated
cataggar Jul 29, 2021
b139a94
mv .gitattributes to root
cataggar Jul 29, 2021
0ec860f
mv .gitattributes
cataggar Jul 29, 2021
086e2df
it is in azext_vmware
cataggar Jul 29, 2021
f26da08
fix style
cataggar Jul 29, 2021
f08c74d
fix linter errors
cataggar Jul 29, 2021
d8cc242
suppress cred scan false positive
cataggar Jul 29, 2021
7a709dc
remove credential test
cataggar Jul 29, 2021
e4d3dfd
Merge remote-tracking branch 'origin/main' into az-vmware-script
cataggar Aug 11, 2021
c7bcd09
raise InvalidArgumentValueError, RequiredArgumentMissingError
cataggar Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix style
  • Loading branch information
@cataggar
cataggar committed Jul 29, 2021
commit f26da082c2951db6edd5135172c081f7abe6752d
7 changes: 4 additions & 3 deletions src/vmware/azext_vmware/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
# pylint: disable=line-too-long, protected-access, too-few-public-methods

import argparse
from typing import Dict, List
Expand Down Expand Up @@ -35,8 +36,8 @@ def __call__(self, parser, namespace, values, option_string=None):

def script_execution_parameters(values: List[str]) -> ScriptExecutionParameter:
values = dict(map(lambda x: x.split('=', 1), values))
type = require(values, "type")
type_lower = type.lower()
tp = require(values, "type")
type_lower = tp.lower()

if type_lower == ScriptExecutionParameterType.VALUE.lower():
try:
Expand All @@ -57,7 +58,7 @@ def script_execution_parameters(values: List[str]) -> ScriptExecutionParameter:
raise CLIError('parsing {} script execution parameter'.format(ScriptExecutionParameterType.CREDENTIAL)) from error

else:
raise CLIError('script execution paramater type \'{}\' not matched'.format(type))
raise CLIError('script execution paramater type \'{}\' not matched'.format(tp))


def require(values: Dict[str, str], key: str) -> str:
Expand Down