Skip to content

Fix 'az webapp config ssl bind' for web apps in kubernetes environments #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panchagnula merged 5 commits into from
Dec 2, 2021
Merged

Fix 'az webapp config ssl bind' for web apps in kubernetes environments #4129

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bc83a1
fix 'az webapp config ssl bind' bug in lima apps
StrawnSC Nov 18, 2021
1f4ccac
start of fix with slots
StrawnSC Nov 29, 2021
f400dca
fix linter issue
StrawnSC Nov 30, 2021
1dbc593
increment setup.py version
StrawnSC Nov 30, 2021
69ea9fb
fix linter issues part II
StrawnSC Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix linter issues part II
  • Loading branch information
@StrawnSC
StrawnSC committed Nov 30, 2021
commit 69ea9fbef44fafe2d8240cfb7eb1b7b076b1d12d
3 changes: 3 additions & 0 deletions src/appservice-kube/azext_appservice_kube/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ def load_arguments(self, _):
c.argument('ssl_type', help='The ssl cert type', arg_type=get_enum_type(['SNI', 'IP']))
c.argument('certificate_thumbprint', help='The ssl cert thumbprint')

with self.argument_context(scope + ' config ssl unbind') as c:
c.argument('certificate_thumbprint', help='The ssl cert thumbprint')

with self.argument_context('appservice') as c:
c.argument('resource_group_name', arg_type=resource_group_name_type)
c.argument('location', arg_type=get_location_type(self.cli_ctx))
Expand Down