Skip to content

Conversation

@usepowershell
Copy link
Contributor

@usepowershell usepowershell commented Apr 20, 2022

This is a preview extension to explore supporting consumption of Azure ContainerApps from a Docker Compose specification.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested a review from yonzhan April 20, 2022 19:41
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 20, 2022
@ghost ghost requested a review from wangzelin007 April 20, 2022 19:41
@ghost ghost assigned zhoxing-ms Apr 20, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 20, 2022
@ghost ghost added the ContainerApp label Apr 20, 2022
@ghost ghost requested review from jsntcy and zhoxing-ms April 20, 2022 19:41
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 20, 2022

containerapp-preview

@panchagnula
Copy link
Contributor

@yonzhan this is a completely different extension from the ACA extension my team owns, hence please have core-cli team review & provide help / feedback. Thanks!

@zhoxing-ms
Copy link
Contributor

File "/home/vsts/work/1/s/src/containerapp-preview/azext_containerapp_preview/custom.py", line 12, in
from azext_containerapp.custom import (
ModuleNotFoundError: No module named 'azext_containerapp'

Could you please fix this import issue?

@zhoxing-ms
Copy link
Contributor

@smurawski Please add exclusion in CredScanSuppressions.json file to solve the Credential Scan issue

@zhoxing-ms
Copy link
Contributor

Please fix the Static Analysis issue

@anthonychu
Copy link
Member

@panchagnula Do you have a suggestion for the extension name? containerapp-preview might be too generic if it's specifically for the compose support.

@panchagnula
Copy link
Contributor

@panchagnula Do you have a suggestion for the extension name? containerapp-preview might be too generic if it's specifically for the compose support.

containerapp-dockercompose?

@usepowershell
Copy link
Contributor Author

@panchagnula Do you have a suggestion for the extension name? containerapp-preview might be too generic if it's specifically for the compose support.

@anthonychu I left the naming of the extension generic as Daria mentioned that there may be more things that you might want to experiment with as the main extension becomes more stable. Happy to change it at any point.

@usepowershell usepowershell marked this pull request as ready for review May 13, 2022 21:14
@usepowershell usepowershell changed the title 🚧 containerapp-preview extension with support for compose files 🚧 containerapp-preview extension with support for compose files May 16, 2022
@usepowershell usepowershell changed the title containerapp-preview extension with support for compose files containerapp-compose extension with support for compose files May 18, 2022
@panchagnula
Copy link
Contributor

@zhoxing-ms , this is something Steven & team planning to release in time for //BUILD for specific scenario support for Azure Container Apps, so please review this when you get a chance so they can make the necessary changes in a timely-fashion on their end as well. Thanks!

@usepowershell
Copy link
Contributor Author

Thank you for the review @zhoxing-ms

I've made the required changes and have rebased on top of main (though that keeps moving).

The build is green again. Anything else I need to address?

@usepowershell
Copy link
Contributor Author

Anything left that would block us getting this shipped @zhoxing-ms ?

@zhoxing-ms zhoxing-ms merged commit c6d86ee into Azure:main Jun 4, 2022
@usepowershell usepowershell deleted the containerapp-preview branch June 6, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants