-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Containerapp Version 0.3.5 : Final release for //BUILD #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
5c144ac
add AZ support
StrawnSC 340e37d
Merge pull request #105 from StrawnSC/az-aca
StrawnSC a637114
bump version, add history, fix style
StrawnSC 5d85708
auto-register Microsoft.App RP
StrawnSC f51df48
autoregister on containerapp and env create
StrawnSC a51745a
Finished auth microsoft.
dac8c2f
Added prototypes of other identity providers.
522e6dd
Added param help.
9be335b
Added error handling for no easy auth case.
0eca228
Adding cmds & tests for Container app certs & domains (#107)
lil131 8185b3f
Merge branch 'containerapp-0.3.5' into autoregister-msft.app
StrawnSC 59369f7
Added auth update and show.
1185d69
Moved utils to utils. Removed CLIErrors from old code. Removed commen…
ea0283d
fixes for CI
StrawnSC 9a85503
use capps RP constant
StrawnSC 6f2943c
Merge pull request #106 from StrawnSC/autoregister-msft.app
StrawnSC 430cee2
rerecord tests; add credscan suppressions
StrawnSC 873e531
Fixed style issues. Fixed sdk version.
5c87013
more CI fixes
StrawnSC 8ad4ae0
Fixed merge conflicts.
11aeb5e
Updated history. Changed constant values instead of using python meth…
873a15f
Added help text for subgroups with examples.
e7137ff
Updated util. Fixed style issues.
8d31890
Merge pull request #108 from haroonf/authconfig
StrawnSC 433433a
Revert "Add auth subgroups" (#109)
runefa 90bfb2a
use new microsoft.graph API
StrawnSC baf9342
wip
StrawnSC d4f6cec
remove unused function
StrawnSC 054db9b
Removed AuthClient sdk.
bbc1842
Added back AuthConfig.
8d31f6a
Removed old references. Limited oidc provider secret name. Fixed warn…
de354e6
Fixed facebook show bug.
87099c6
adding hostname tests with ASD
lil131 8f31760
fix location & add more test cases
lil131 b7f37a1
minor changes
lil131 699d2fc
rm redundant whitespaces
lil131 2ba057f
mark custom domain test as live_only
lil131 e3b3a59
Fixed error handling.
cf297ae
rm yaml files
lil131 2d39def
Merge pull request #110 from StrawnSC/microsoft.graph
StrawnSC 4739052
add breaking change history note
StrawnSC a6fb46d
Merge pull request #112 from lil131/location-fix
StrawnSC 1e977dd
Merge branch 'containerapp-0.3.5' into authconfig
StrawnSC e5237b6
bug fix in 'az containerapp auth update'
StrawnSC 4b9eaab
Merge pull request #111 from haroonf/authconfig
StrawnSC 8124269
remove dependencies on core CLI role module functions
StrawnSC 0ae7357
remove 'BREAKING CHANGE' from history entry
StrawnSC 6c86217
resolve PR comments
StrawnSC b671136
add test recording and remove live_only
StrawnSC 881dbd8
make live only test live_only again
StrawnSC 59eb990
remove unnecessary option lists
StrawnSC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these requests not considered to be implemented in the Python SDK method, but directly request the REST service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms our plan with the
az containerappcommands was to use raw requests while in the extension, and then use the SDK when we put this in a core CLI command module -- similar to theappservice-kubecommands. This has helped us keep the extension install size down and add features independently of their support in the SDK. We were under the impression that using raw requests is not allowed in the core CLI but permissible in CLI extensionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms , @StrawnSC is right - the swagger & Python SDK changes were too delayed for us to take a dependency on this. POST GA we plan to move this to using SDK completely + maybe move to core-cli as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks~