{AKS} Integrate azuredisk csi driver version to cli #4865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edreed
reviewed
May 20, 2022
edreed
reviewed
May 20, 2022
edreed
reviewed
May 20, 2022
Collaborator
|
aks |
mukhoakash
force-pushed
the
mukhoakash/driverversion
branch
from
d5a27dc to
8519d83
Compare
FumingZhang
changed the title
FumingZhang
reviewed
May 22, 2022
FumingZhang
reviewed
May 22, 2022
FumingZhang
reviewed
May 22, 2022
andyzhangx
reviewed
May 23, 2022
…hoakash/driverversion
FumingZhang
reviewed
May 26, 2022
Member
|
Queued a pipeline to test modified test cases. |
andyzhangx
reviewed
May 27, 2022
Contributor
Author
@FumingZhang Tests seemed to run on westus2 instead of canary location. |
Member
OK, queued another pipeline to test these cases. All passed. |
FumingZhang
approved these changes
May 30, 2022
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please also fix the conflict about version in HISTORY.rst and setup.py.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
May 30, 2022
zhoxing-ms
approved these changes
May 30, 2022
FumingZhang
added a commit
to FumingZhang/azure-cli-extensions
that referenced
this pull request
Jun 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to the az cli
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.