Skip to content

Conversation

@asottile
Copy link
Contributor

resolves #4910


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az webpubsub

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required) (NO)
  • Have you run python scripts/ci/test_index.py -q locally? (NO)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 29, 2022
@ghost
Copy link

ghost commented May 29, 2022

Thank you for your contribution asottile! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested a review from kairu-ms May 29, 2022 23:34
@yonzhan yonzhan requested a review from necusjz May 29, 2022 23:34
@yonzhan yonzhan added this to the Jun 2022 (2022-07-05) milestone May 29, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 29, 2022

webpubsub

@necusjz necusjz changed the title allow newer versions of websockets for webpubsub [Web PubSub] Allow newer versions of websockets Jun 2, 2022
@necusjz necusjz merged commit 38f1124 into Azure:main Jun 2, 2022
@asottile asottile deleted the patch-1 branch October 20, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

az webpubsub client start errors with TypeError: As of 3.10, the *loop* parameter was removed from Lock() since it is no longer necessary

4 participants