Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Oct 17, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

  • {AKS} Vendor 2022-09-02-preview for aks-preview.
  • Update default test matrix.
    • Add test_aks_create_and_update_with_http_proxy_config, test_aks_snapshot back.
  • Remove several @live_only tags.
    • test_get_version
    • test_get_os_options
    • test_aks_disable_local_accounts
  • Fix test case test_aks_addon_show_openservicemesh_enabled, remove identity check (sync rp change)
  • Fix test case test_aks_update_with_azuremonitormetrics, update vm sku.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms October 17, 2022 07:47
@ghost ghost assigned zhoxing-ms Oct 17, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 17, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 17, 2022
@ghost ghost requested a review from yonzhan October 17, 2022 07:47
@ghost ghost added the AKS label Oct 17, 2022
@FumingZhang
Copy link
Member Author

Rerun live tests to update recordings in pipeline.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review October 18, 2022 07:37
@FumingZhang FumingZhang force-pushed the fuming/vendor-sdk-aks-preview-1017 branch from 2b95fd7 to bd177db Compare October 18, 2022 08:10
@FumingZhang FumingZhang force-pushed the fuming/vendor-sdk-aks-preview-1017 branch from 3daa866 to e5e201e Compare October 18, 2022 09:53
@evelyn-ys evelyn-ys merged commit 7fcf94d into Azure:main Oct 18, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=9532&view=results

@FumingZhang FumingZhang deleted the fuming/vendor-sdk-aks-preview-1017 branch December 8, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants