[AKS] Mark "--enable-pod-security-policy" deprecated #5542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
FumingZhang and
andyliuliming
as code owners
ghost
requested review from
ghost
assigned
bingosummer
force-pushed
the
aks-psp-deprecation
branch
from
5ed1ef0 to
f22db45
Compare
Collaborator
|
AKS |
FumingZhang
approved these changes
Nov 14, 2022
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM.
To clarify, the deprecated option has no corresponding replacement in CLI. According to the doc, the alternative is to use kubectl to add labels directly to the cluster namespace.
karataliu
approved these changes
Nov 14, 2022
Contributor
|
@bingosummer If you want to release a new extension version to release this change, please also upgrade the version defined in |
Member
Author
@zhoxing-ms Thanks! The fix doesn't need a release. It can be released with other PR's changes later. |
zhoxing-ms
reviewed
Nov 14, 2022
zhoxing-ms
reviewed
Nov 14, 2022
zhoxing-ms
reviewed
Nov 14, 2022
zhoxing-ms
reviewed
Nov 14, 2022
bingosummer
force-pushed
the
aks-psp-deprecation
branch
from
f22db45 to
760470c
Compare
Member
Author
|
@zhoxing-ms Thanks for reviews! Resolved the comments. |
Member
Author
|
After removing help, CI raises the below error. Will add them back. |
bingosummer
force-pushed
the
aks-psp-deprecation
branch
from
760470c to
c2f52cc
Compare
zhoxing-ms
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark PodSecurityPolicy deprecated because PodSecurityPolicy was deprecated in Kubernetes v1.21, and removed from Kubernetes in v1.25.