Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

[AKS] az aks nodepool: Unify the option names used to specify the nodepool name and cluster name. For nodepool name, option names are --nodepool-name, --name and -n. For cluster name, option name is --cluster-name

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms November 28, 2022 07:29
@ghost ghost assigned zhoxing-ms Nov 28, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 28, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 28, 2022
@ghost ghost requested a review from yonzhan November 28, 2022 07:29
@ghost ghost added the AKS label Nov 28, 2022
@FumingZhang
Copy link
Member Author

See mirror PR #24754 in azure-cli.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 28, 2022

AKS

@FumingZhang FumingZhang changed the title {AKS} az aks nodepool: Update nodepool command option names {AKS} az aks nodepool: Update nodepool command option names Nov 28, 2022
@FumingZhang FumingZhang marked this pull request as ready for review November 29, 2022 02:17
@zhoxing-ms zhoxing-ms merged commit 0127284 into Azure:main Nov 29, 2022
@FumingZhang FumingZhang deleted the fuming/align-nodepool-names-1128 branch December 8, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants