Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Remove defender related code after GA, reuse the implementation in azure-cli/acs.
  • May refer to PR #23291 in azure-cli.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yanzhudd and zhoxing-ms December 14, 2022 07:33
@ghost ghost assigned zhoxing-ms Dec 14, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 14, 2022
@ghost ghost requested a review from yonzhan December 14, 2022 07:33
@ghost ghost added the AKS label Dec 14, 2022
@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 14, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 14, 2022

AKS

@zhoxing-ms zhoxing-ms merged commit fe7cc2d into Azure:main Dec 14, 2022
@FumingZhang FumingZhang deleted the fuming/GA-defender-1214 branch December 30, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants