Skip to content

Conversation

@yadongyaly
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

datamigration sql-db create

Add description in "help".
If the customer does not have table in the target database, suggest them to use "az datamigration sql-server-schema" command to do schema migration firstly.

Checklist

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 7, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @yadongyaly,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 7, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yadongyaly
Copy link
Contributor Author

Hi @yonzhan @evelyn-ys @calvinhzy may I get a review on this tiny PR? The change is only adding more descriptions.

@evelyn-ys evelyn-ys merged commit e610854 into Azure:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants