Skip to content

Conversation

@gaoyp830
Copy link
Contributor

@gaoyp830 gaoyp830 commented Aug 8, 2023

…parameter


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 8, 2023

❌Azure CLI Extensions Breaking Change Test
❌reservation
rule cmd_name rule_message suggest_message
1007 - ParaRemove reservations catalog show cmd reservations catalog show removed parameter skip please add back parameter skip for cmd reservations catalog show
1007 - ParaRemove reservations catalog show cmd reservations catalog show removed parameter take please add back parameter take for cmd reservations catalog show
⚠️ 1006 - ParaAdd reservations list cmd reservations list added parameter pagination_limit
⚠️ 1006 - ParaAdd reservations list cmd reservations list added parameter pagination_token
⚠️ 1006 - ParaAdd reservations reservation list cmd reservations reservation list added parameter pagination_limit
⚠️ 1006 - ParaAdd reservations reservation list cmd reservations reservation list added parameter pagination_token
⚠️ 1006 - ParaAdd reservations reservation list-history cmd reservations reservation list-history added parameter pagination_limit
⚠️ 1006 - ParaAdd reservations reservation list-history cmd reservations reservation list-history added parameter pagination_token
⚠️ 1006 - ParaAdd reservations reservation-order list cmd reservations reservation-order list added parameter pagination_limit
⚠️ 1006 - ParaAdd reservations reservation-order list cmd reservations reservation-order list added parameter pagination_token

@azure-client-tools-bot-prd
Copy link

Hi @gaoyp830,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 8, 2023

Az.Reservations

@gaoyp830
Copy link
Contributor Author

Related change in swagger Azure/azure-rest-api-specs#25192

@gaoyp830 gaoyp830 marked this pull request as ready for review August 15, 2023 01:53
@kairu-ms kairu-ms merged commit 2a0f066 into Azure:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants