Skip to content

Conversation

@calvinhzy
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Aug 11, 2023
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 11, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️storage-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd storage account migration sub group storage account migration added

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 11, 2023

Storage-Preview

@calvinhzy calvinhzy marked this pull request as ready for review August 11, 2023 06:31
@register_command(
"storage account migration start",
is_preview=True,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this command long running operation? Does this support --no-wait?

@calvinhzy calvinhzy merged commit 7853e98 into Azure:main Aug 11, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ storage-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=81755&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants