Skip to content

Conversation

@Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp job
az containerapp env storage
az containerapp env workload-profile
az containerapp hostname add
az containerapp update/create
az containerapp revision copy
az containerapp hostname bind

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 14, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1004 - CmdPropRemove containerapp env storage list cmd containerapp env storage list removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env storage remove cmd containerapp env storage remove removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env storage set cmd containerapp env storage set removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env storage show cmd containerapp env storage show removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile add cmd containerapp env workload-profile add removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile delete cmd containerapp env workload-profile delete removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile list cmd containerapp env workload-profile list removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile list-supported cmd containerapp env workload-profile list-supported removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile set cmd containerapp env workload-profile set removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile show cmd containerapp env workload-profile show removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env workload-profile update cmd containerapp env workload-profile update removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp hostname add cmd containerapp hostname add removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job create cmd containerapp job create removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job delete cmd containerapp job delete removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job list cmd containerapp job list removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job show cmd containerapp job show removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job start cmd containerapp job start removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job stop cmd containerapp job stop removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp job update cmd containerapp job update removed property is_preview

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
This PR has been reviewed by hong, could you help to review and merge? Thanks.

@zhoxing-ms zhoxing-ms merged commit d5b7a4b into Azure:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants