Skip to content

{CI} Add new comment to explain the reason that pin the wheel to 0.30.0 #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangzelin007 merged 2 commits into from
Oct 10, 2023
Merged

{CI} Add new comment to explain the reason that pin the wheel to 0.30.0 #6842

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4020b3
Update test_index.py
wangzelin007 Oct 8, 2023
1b1468e
Update pull_request_template.md
wangzelin007 Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update test_index.py
  • Loading branch information
@wangzelin007
wangzelin007 committed Oct 8, 2023
commit d4020b3c8fc46ee159da2a3422e4f574bd45c25d
2 changes: 2 additions & 0 deletions scripts/ci/test_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ def test_extension_filenames(self):
"Extension name mismatch in extensions['{}']. "
"Found an extension in the list with name "
"{}".format(ext_name, item['metadata']['name']))
# Due to https://github.com/pypa/wheel/issues/235 we prevent whls built with 0.31.0 or greater.
# 0.29.0, 0.30.0 are the two previous versions before that release.
parsed_filename = WHEEL_INFO_RE(item['filename'])
p = parsed_filename.groupdict()
self.assertTrue(p.get('name'), "Can't get name for {}".format(item['filename']))
Expand Down