-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Subscription } Migrate subscription to AAZ #8133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| account create | cmd account create added parameter no_wait |
||
| account create | cmd account create update parameter display_name: added property aaz_type=string |
||
| account create | cmd account create update parameter display_name: added property type=string |
||
| account create | cmd account create update parameter enrollment_account_name: added property aaz_type=string |
||
| account create | cmd account create update parameter enrollment_account_name: added property type=string |
||
| account create | cmd account create update parameter enrollment_account_name: updated property name from enrollment_account_name to enrollment_account_object_id |
||
| account create | cmd account create update parameter offer_type: added property aaz_type=string |
||
| account create | cmd account create update parameter offer_type: added property type=string |
||
| account create | cmd account create update parameter owner_object_id: added property aaz_type=string |
||
| account create | cmd account create update parameter owner_object_id: added property type=string |
||
| account create | cmd account create update parameter owner_spn: added property aaz_type=string |
||
| account create | cmd account create update parameter owner_spn: added property type=string |
||
| account create | cmd account create update parameter owner_upn: added property aaz_type=string |
||
| account create | cmd account create update parameter owner_upn: added property type=string |
|
Hi @Jing-song, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Jing-song
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please verify the choices changed for offer-type argument in the breaking change log: from ['MS-AZR-0017P', 'MS-AZR-0148P', 'MS-AZR-USGOV-0015P', 'MS-AZR-USGOV-0017P', 'MS-AZR-USGOV-0148P'] to ['MS-AZR-0017P', 'MS-AZR-0148P'] |
|
[Release] Update index.json for extension [ subscription ] : https://dev.azure.com/azclitools/release/_build/results?buildId=198298&view=results |
| tenant_id, | ||
| base_url=cli_ctx.cloud.endpoints.active_directory_graph_resource_id) | ||
| from azure.cli.command_modules.role import graph_client_factory | ||
| graph_client = graph_client_factory(cli_ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new azure.cli.command_modules.role._msgrpah._graph_client.GraphClient is very different from azure.graphrbac.GraphRbacManagementClient. See
- https://learn.microsoft.com/en-us/cli/azure/microsoft-graph-migration
- https://github.com/Azure/azure-cli/blob/dev/doc/microsoft_graph_client.md
A simple replacement will break things such as Azure/azure-cli#30390.
Azure/azure-cli#28105 introduced some centralized functions in azure.cli.command_modules.role.util for object ID resolution.
This checklist is used to make sure that common guidelines for a pull request are followed.
Migrate subscription to AAZ
AAZ model: Azure/aaz#587
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.