-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS}: fix subscription id not correctly set in helm chart #9467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes a bug where the subscription ID field name in the helm chart values was incorrectly set. The field name is changed from subscriptionId to subscriptionID to match the expected helm chart schema.
- Corrected the subscription ID field name from "subscriptionId" to "subscriptionID" in the AKS context helm values
- Bumped the extension version from 1.0.0b12 to 1.0.0b13
- Updated the release history with the bug fix description
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-agent/setup.py | Version bump from 1.0.0b12 to 1.0.0b13 |
| src/aks-agent/azext_aks_agent/agent/k8s/aks_agent_manager.py | Fixed the subscription ID field name in helm values from "subscriptionId" to "subscriptionID" |
| src/aks-agent/HISTORY.rst | Added release notes for version 1.0.0b13 documenting the subscription ID fix |
|
[Release] Update index.json for extension [ aks-agent-1.0.0b13 ] : https://dev.azure.com/msazure/One/_build/results?buildId=146302359&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.