-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ARM] Refactor deployment commands #10751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
095b3f9
update SDK version.
Tiano2017 4caf537
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 c3a4b58
Refactor az deployment commands.
Tiano2017 432c2e9
record tests.
Tiano2017 c006d43
test recordings.
Tiano2017 2d6cb8d
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 d9863fb
test recordings.
Tiano2017 87f5ff2
more recordings.
Tiano2017 8572bf6
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 d33db76
more recordings.
Tiano2017 4734036
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 458bbca
more recordings.
Tiano2017 282710b
more recordings.
Tiano2017 9c58de5
more recordings.
Tiano2017 af06e49
short parametes.
Tiano2017 80f9fb9
fix style and linter issues.
Tiano2017 f3ea38e
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 0bbf8ba
fix linter failure.
Tiano2017 16b4645
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 7bd0782
recording.
Tiano2017 844ba11
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 c53d069
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 ea2b273
resolve conflicts.
Tiano2017 1dcd3dd
revert changes that are not needed.
Tiano2017 ff28c45
refactor.
Tiano2017 f0ce838
clean up.
Tiano2017 86e02e1
fix help.
Tiano2017 5b913c0
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 1da1d49
create parameter types.
Tiano2017 d24145c
refactor.
Tiano2017 c9080cb
fix style.
Tiano2017 5e92470
test recordings.
Tiano2017 0e03020
more recordings.
Tiano2017 7e37f3d
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 58f2a5a
fixes.
Tiano2017 1e0980c
Fix deployment manager test.
Tiano2017 0c1fc1f
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 c6a4ab5
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 75acad1
address comments.
Tiano2017 40a69f9
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 849eac9
fix for handle-extended-json-format
Tiano2017 53e18e6
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 b7affe8
Fix tests.
Tiano2017 7a6853e
dummy change.
Tiano2017 f5c8c58
fix style.
Tiano2017 4f93025
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 e19f0ff
merge and resolve conflicts.
Tiano2017 a808d26
record test.
Tiano2017 302e52a
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 430ab92
trigger CI run again.
Tiano2017 ee17865
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 1e1b69b
Fix change history.
Tiano2017 15e6645
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 1d0895f
Use ResourceGroupPreparer for deployment test at resource group
Tiano2017 c7ad2a5
fix style.
Tiano2017 a6b8df0
revert changes in HISTORY.rst
Tiano2017 2d3fbbe
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 ab8aac8
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 9753fc1
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 c10d6a2
fix linter.
Tiano2017 65d7231
record test.
Tiano2017 a3d3e93
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
Tiano2017 3e9459f
refactor.
Tiano2017 30c4c7a
fix min_api and add deprecate info.
Tiano2017 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge remote-tracking branch 'Azure/dev' into tiano-tenant-deployment
# Conflicts: # src/azure-cli/azure/cli/command_modules/resource/custom.py # src/azure-cli/azure/cli/command_modules/resource/tests/latest/recordings/test_group_deployment.yaml # src/azure-cli/azure/cli/command_modules/resource/tests/latest/recordings/test_group_deployment_crossrg.yaml
- Loading branch information
commit 53e18e6409bdd28dc5db9fd2850a7d8718461950
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you do not check validate_only in this method now, is there any reason for this? And why do you not use sdk_no_wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to do validate for both validate and create, so we are not checking validate_only. we don't need sdk_no_wait because the validate API is not a long running operation.