Skip to content

[ACS] aks create/update: add --load-balancer-outbound-ports and --load-balancer-idle-timeout #11960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 15 commits into from
Jan 31, 2020
Merged

[ACS] aks create/update: add --load-balancer-outbound-ports and --load-balancer-idle-timeout #11960

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
55eb56f
fix merge conflicts, update containerservice version
gtracer Jan 27, 2020
7b85897
enable allocated ports and idletimeouts
gtracer Jan 27, 2020
d98ed4b
add validation, help doc, fix linting
gtracer Jan 27, 2020
bb1caa3
move lb to file
gtracer Jan 28, 2020
3d7ddb1
refactor for patch, update naming
gtracer Jan 28, 2020
62613d8
update history
gtracer Jan 28, 2020
28fcdd4
update setup file to latest acs version
gtracer Jan 28, 2020
476cbfe
feedback: update history, help docs and port validator
gtracer Jan 29, 2020
dc388f5
fix merge conflicts
gtracer Jan 29, 2020
1bd6942
feedback:int not string, typo
gtracer Jan 29, 2020
c61a6e3
int not string
gtracer Jan 29, 2020
46363c3
add blank line
gtracer Jan 29, 2020
5b4f0da
use logger instead of print
qwordy Jan 31, 2020
c3ab4e1
Update _loadbalancer.py
qwordy Jan 31, 2020
bdabf26
Update _loadbalancer.py
qwordy Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update _loadbalancer.py
  • Loading branch information
@qwordy
qwordy authored Jan 31, 2020
commit bdabf26809dcfa99eb4592ba5a2a037b95c994f5
5 changes: 3 additions & 2 deletions src/azure-cli/azure/cli/command_modules/acs/_loadbalancer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ def set_load_balancer_sku(sku, kubernetes_version):
if sku:
return sku
if kubernetes_version and StrictVersion(kubernetes_version) < StrictVersion("1.13.0"):
logger.warning('Setting load_balancer_sku to basic as it is not specified and kubernetes \
version({}) less than 1.13.0 only supports basic load balancer SKU\n'.format(kubernetes_version))
logger.warning('Setting load_balancer_sku to basic as it is not specified and kubernetes'
'version(%s) less than 1.13.0 only supports basic load balancer SKU\n',
kubernetes_version)
return "basic"
return "standard"

Expand Down