Skip to content

[SQL] BREAKING CHANGE: az sql db create: Remove WideWorldImportersStd and WideWorldImportersFull as allowed values for --sample-name values #11976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juliehzl merged 3 commits into from
Jan 30, 2020
Merged

[SQL] BREAKING CHANGE: az sql db create: Remove WideWorldImportersStd and WideWorldImportersFull as allowed values for --sample-name values #11976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa386c
Remove WideWorldImporters as allowed values for sql db sample name
jaredmoo Jan 29, 2020
5efc6cd
format history
Juliehzl Jan 30, 2020
f9969ea
Merge branch 'dev' into remove_wwi_samplename
Juliehzl Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove WideWorldImporters as allowed values for sql db sample name 
The WideWorldImportersStd and WideWorldImportersFull sql db samples were never supported in production and were only documented here by mistake. Removing them from allowed values so that users do not attempt to create them. Note that this is not a breaking change because these options already caused db creation to fail.
  • Loading branch information
@jaredmoo
jaredmoo committed Jan 29, 2020
commit aaa386c7e1441c8780be7f91cd1ba535b1845c98
1 change: 1 addition & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ Release History
**SQL**

* Added "--read-scale" and "--read-replicas" parameters to sql db create and update commands, to support read scale management.
* Remove "WideWorldImportersStd" and "WideWorldImportersFull" as documented allowed values for "az sql db create --sample-name". These sample databases would always cause creation to fail.

**SQL VM**

Expand Down
4 changes: 3 additions & 1 deletion src/azure-cli/azure/cli/command_modules/sql/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,11 @@ def load_arguments(self, _):
arg_group=creation_arg_group,
arg_type=get_enum_type(CatalogCollationType))

# WideWorldImportersStd and WideWorldImportersFull cannot be successfully created.
# AdventureWorksLT is the only sample name that is actually supported.
c.argument('sample_name',
arg_group=creation_arg_group,
arg_type=get_enum_type(SampleName))
arg_type=get_enum_type([SampleName.adventure_works_lt]))

c.argument('license_type',
arg_type=get_enum_type(DatabaseLicenseType))
Expand Down