[EventHub] az eventhubs eventhub create/update: Change documentation of destination_name #12747
Conversation
We need to know the allowed variables for running the command with --destination-name.
|
add to S167 |
zhoxing-ms
left a comment
zhoxing-ms
left a comment
There was a problem hiding this comment.
@brunomartinspro Hi, this PR title is not in the right format, please modify the PR title and description. For details, refer to: doc link
brunomartinspro
changed the title
brunomartinspro
changed the title
Hi @zhoxing-ms ! Is it okay now? If not what should I change it to? |
brunomartinspro
changed the title
brunomartinspro
changed the title
|
@zhoxing-ms @yonzhan the builds have passed! 👍 |
|
@brunomartinspro If your requirements are related to specific commands, you can add the corresponding command to the title, like:
|
Okay but since I only updated the documentation, is it not enough “[EventHub] Change documentation of destination_name”? |
|
@brunomartinspro You might write it like this: |
brunomartinspro
changed the title
@zhoxing-ms i updated to your recommendation, thanks! |
|
@v-Ajnava any news on this? |
v-Ajnava
left a comment
v-Ajnava
left a comment
There was a problem hiding this comment.
currently we are not supporting 'EventHubArchive.AzureDataLake', we will need to remove Datalake part
| c.argument('capture_interval_seconds', arg_group='Capture', options_list=['--capture-interval'], type=int, help='Allows you to set the frequency with which the capture to Azure Blobs will happen, value should between 60 to 900 seconds') | ||
| c.argument('capture_size_limit_bytes', arg_group='Capture', options_list=['--capture-size-limit'], type=int, help='Defines the amount of data built up in your Event Hub before an capture operation, value should be between 10485760 to 524288000 bytes') | ||
| c.argument('destination_name', arg_group='Capture-Destination', help='Name for capture destination') | ||
| c.argument('destination_name', arg_group='Capture-Destination', help='Name for capture destination, EventHubArchive.AzureBlockBlob or EventHubArchive.AzureDataLake.') |
There was a problem hiding this comment.
currently we are not supporting 'EventHubArchive.AzureDataLake' in clients, its a swagger issue. we will need to remove Datalake part
|
add to S170 |
|
add to S171 |
|
add to S172 |
|
@brunomartinspro Hi, could you please take a look at the new request from v-Ajnava? Is there any update? |
|
Because there is no reply for a long time, so I tag it |
|
@zhoxing-ms @yonzhan Added the pull request recommendations. |
|
@v-Ajnava Could you please help to review it again |
|
@v-Ajnava please help take a look at the PR. Without your approval, we could not merge the PR. |
azure-sdk
added
the
customer-reported
7 participants
Description of PR (Mandatory)
We need to know the allowed variables for running the command with --destination-name.
This only changes the documentation on https://docs.microsoft.com/en-us/cli/azure/eventhubs/eventhub
This checklist is used to make sure that common guidelines for a pull request are followed.
[ x] The PR title and description has followed the guideline in Submitting Pull Requests.
[ x] I adhere to the Command Guidelines.
#10031