{Resource} Remove resource test test_resource_policyset from profile 2018-03-01-hybrid #13172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
test_resource_policysetunder profile 2018-03-01-hybrid is invalid, because of its maxmium API version for policy is2016-12-01:azure-cli/src/azure-cli-core/azure/cli/core/profiles/_shared.py
Lines 223 to 229 in b93fab1
and the
policy set-definitioncommand wish to onboard only in API2017-06-01-previewand higher:azure-cli/src/azure-cli/azure/cli/command_modules/resource/commands.py
Lines 355 to 360 in b93fab1
The test
test_resoure_policysetis using the command grouppolicy set-defintion, it's not correct.Guessing it's added by mistake sicne the original migration.
Testing Guide
A small bug fix need to make, the decorator above
test_resource_policysetneed to change fromAllowLargeResponsetoAllowLargeResponse()then make the test to be correctly executed.Then, run
azdev test --live test_resource_policyset --profile 2018-03-01-hybridit would fail.History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.