{Packaging} Remove wheel as a runtime dependency #13230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
remove wheel |
Contributor
|
Fix #12582 |
haroldrandom
approved these changes
Apr 28, 2020
fengzhou-msft
changed the title
fengzhou-msft
requested review from
Juliehzl,
arrownj,
jiasli and
qianwens
as code owners
fengzhou-msft
commented
Apr 29, 2020
| 'msrest>=0.4.4', | ||
| 'msrestazure>=0.6.3', | ||
| 'paramiko>=2.0.8,<3.0.0', | ||
| 'pkginfo', |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wheel should not be needed to run Azure CLI. It is only used in packaging.
To remove wheel from azure-cli-core dependencies, we need to install wheel in packaging scripts.
It seems they're already doing this, will check them one by one.Verified that MSI, homebrew and pypi use setup.py to build wheels during packaging, and their script all include a step to install wheel. Other packages use requirements file to install dependency, wheel is not used.For the packaging of extensions, as azdev has the dependency of wheel, it should be fine.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.