[ACS] bug fix: remove fields cleanup for fields that no longer exist #13315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
add to S169 |
yungezz
approved these changes
May 6, 2020
Member
|
hi @arrownj could you pls review the PR? thanks |
qwordy
approved these changes
May 6, 2020
arrownj
approved these changes
May 7, 2020
2 tasks
olga-mir
pushed a commit
to olga-mir/azure-cli
that referenced
this pull request
May 21, 2020
This reverts commit cd405fa.
arrownj
pushed a commit
that referenced
this pull request
Jun 8, 2020
* Revert "ACS: remove fields cleanup that no longer exist (#13315)" This reverts commit cd405fa. * Revert "[ACS] BREAKING CHANGE: ARO remove vnet-peer, upgrade to 2019-10-27-preview API version (#12240)" This reverts commit 32e5102. Co-authored-by: Olga Mirensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an error introduced in #12240 where AROv3 has been upgraded to latest API version. Fields
nameandos_typehas been dropped from master pool profile in azure-sdk-for-python: https://github.com/Azure/azure-sdk-for-python/pull/10464/filesTesting Guide
create an OpenShift cluster
az openshift create -g <group_name> -n <resource_name> --location eastus2try show or list command:
az openshift listaz openshift show -g <group_name> -n <resource_name>They should execute without error and display the cluster info.
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.